Fix reflow case where wrapped line portions ended in \t #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still can reproduce issues with demo: I'm resizing from 10 to 82 cols and back several times and getting strange ouput. Do i do something wrong? |
|
@akosyakov other terminals do things like that when you resize into the prompt when I tested, we're just doing what the shell is telling us. You're not seeing the exception that could brick the terminal though right? |
|
@Tyriar no errors in dev console |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1932
The tests explain the problem pretty well, the tricky thing here was fixing this issue while still keeping the correct behavior of moving wide characters to the following line which is why the fix is more complex than one would expect.