WebLinks plugin don't follow link on selection #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Mar 7, 2019
Tyriar
requested changes
Mar 8, 2019
There was a problem hiding this comment.
Actually after further testing and thinking on this I don't think we can go this direction as then people can't click links if they have any selection. What we we add a mousedown listener in MouseZoneManager which measures the length of the selection, and verify it hasn't checked in MouseZoneManager._onClick instead?
|
That seems like a better approach to this problem.. I'll try to have a POC during the week! 😄 |
|
After some testing, the recommended approach seems to be working! Awaiting review 😃 |
10 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the correct solution, but it's something to get the ball rolling...
Feedback on what's the best approach is welcome, right now it is in a working state, but I believe we should be smarter about this... I have 2 questions regarding how to proceed:
Linkifier?Fixes #1947