-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signal sequence was finally handled #1923
Conversation
What if we change it to |
@Tyriar Hmm yeah, tbh I dont like adding all those return values either. Guess I'd do it your way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerch I made the changes, please review and merge if they look good 🙂
@Tyriar 👍 |
Inputhandler methods did not yet follow the paradigm to return
true
if a sequence was finally handled, thus the fallback handler get called. Fixes #1879.