Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal sequence was finally handled #1923

Merged
merged 10 commits into from
Apr 9, 2019
Merged

signal sequence was finally handled #1923

merged 10 commits into from
Apr 9, 2019

Conversation

jerch
Copy link
Member

@jerch jerch commented Feb 1, 2019

Inputhandler methods did not yet follow the paradigm to return true if a sequence was finally handled, thus the fallback handler get called. Fixes #1879.

@jerch jerch added this to the 3.12.0 milestone Feb 1, 2019
@jerch jerch self-assigned this Feb 1, 2019
@jerch jerch changed the title signal sequences was handled signal sequence was finally handled Feb 1, 2019
@Tyriar
Copy link
Member

Tyriar commented Feb 2, 2019

What if we change it to callback: (params: number[], collect: string) => boolean | undefined and only when it's false (not undefined) will it be treated as not handled? Would save adding all this extra code to InputHandler.

@jerch
Copy link
Member Author

jerch commented Feb 3, 2019

@Tyriar Hmm yeah, tbh I dont like adding all those return values either. Guess I'd do it your way.

@Tyriar Tyriar added the work-in-progress Do not merge label Mar 4, 2019
@Tyriar Tyriar modified the milestones: 3.12.0, 3.13.0 Mar 8, 2019
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerch I made the changes, please review and merge if they look good 🙂

@Tyriar Tyriar removed the work-in-progress Do not merge label Apr 6, 2019
@Tyriar Tyriar merged commit 660466d into xtermjs:master Apr 9, 2019
@jerch
Copy link
Member Author

jerch commented Apr 25, 2019

@Tyriar 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fallback handler wrongly called for OSC and CSI
2 participants