Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tsconfig baseUrl and absolute imports #1314

Closed
Tyriar opened this issue Mar 8, 2018 · 1 comment · Fixed by #2132
Closed

Use tsconfig baseUrl and absolute imports #1314

Tyriar opened this issue Mar 8, 2018 · 1 comment · Fixed by #2132
Assignees
@Tyriar
Labels
breaking-change Breaks API and requires a major version bump type/debt Technical debt that could slow us down in the long run
Milestone
4.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 8, 2018

I tried to do this last week but ran into issues with the way our build process works. I think the issue was lib/ trying to find things that only existed in src/ or something. Moving the tsconfig.json into the src/ directory might fix this.
@Tyriar Tyriar added help wanted type/debt Technical debt that could slow us down in the long run labels Mar 8, 2018
@Tyriar Tyriar mentioned this issue Mar 8, 2018
Merged
@Tyriar Tyriar mentioned this issue Jun 10, 2018
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 10, 2019
@Tyriar
Make common use non-relative imports
b07a435 
Part of xtermjs#1314
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 10, 2019
@Tyriar
Make core use non-relative imports
a97e692 
Part of xtermjs#1314
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 10, 2019
@Tyriar
Convert main project to use non-relative imports
f6658aa 
Part of xtermjs#1314
@Tyriar Tyriar mentioned this issue Apr 10, 2019
Closed
@Tyriar Tyriar added this to the 3.13.0 milestone Apr 10, 2019
@Tyriar Tyriar self-assigned this Apr 10, 2019
@Tyriar Tyriar removed this from the 3.13.0 milestone Apr 12, 2019
@Tyriar
Copy link
Member Author

Tyriar commented May 26, 2019

Looking into this more today, it looks like we can do it if we webpack the current lib and export that as the main file. This will also come with the benefit of (finally) minifying the lib we ship, we might want to revise how the dist/ build works though.

@Tyriar Tyriar added this to the 4.0.0 milestone May 26, 2019
@Tyriar Tyriar mentioned this issue May 26, 2019
Merged
5 tasks
@Tyriar Tyriar added the breaking-change Breaks API and requires a major version bump label May 26, 2019
@Tyriar Tyriar mentioned this issue May 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
breaking-change Breaks API and requires a major version bump type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
4.0.0
1 participant
@Tyriar