Skip to content

Commit

Permalink
Merge pull request #3239 from hantatsang/fix/2642-terminal-open-check…
Browse files Browse the repository at this point in the history
…-shadow-dom

Terminal.open: support WebComponent when checking DOM Node
  • Loading branch information
Tyriar authored Feb 1, 2021
2 parents 4b29b8a + a0903fb commit d84576e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/browser/Terminal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ export class Terminal extends CoreTerminal implements ITerminal {
throw new Error('Terminal requires a parent element.');
}

if (!document.body.contains(parent)) {
if (!parent.isConnected) {
this._logService.debug('Terminal.open was called on an element that was not attached to the DOM');
}

Expand Down

0 comments on commit d84576e

Please sign in to comment.