Avoid lgamma issue on arm on lgamma(2) by hardcoding the output result

xtensor-stack · May 18, 2024 · 62a3e13 · 62a3e13
1 parent 5ac7edf
commit 62a3e13
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/include/xsimd/arch/generic/xsimd_generic_math.hpp b/include/xsimd/arch/generic/xsimd_generic_math.hpp
@@ -1244,6 +1244,8 @@ namespace xsimd
                             return r;
                     }
                     batch_type r2 = select(ltza, r, r1);
+                    // FIXME: added to avoid producing -nan here
+                    r2 = select((a == 1) || (a == 2), batch_type(0), r2);
                     return select(a == constants::minusinfinity<batch_type>(), constants::nan<batch_type>(), select(inf_result, constants::infinity<batch_type>(), r2));
                 }
 

diff --git a/test/test_xsimd_api.cpp b/test/test_xsimd_api.cpp
@@ -627,8 +627,10 @@ struct xsimd_api_float_types_functions
     }
     void test_lgamma()
     {
-        value_type val(2);
-        CHECK_EQ(extract(xsimd::lgamma(T(val))), std::lgamma(val));
+        value_type val0(2);
+        CHECK_EQ(extract(xsimd::lgamma(T(val0))), std::lgamma(val0));
+        value_type val1(.5);
+        CHECK_EQ(extract(xsimd::lgamma(T(val1))), std::lgamma(val1));
     }
     void test_log()
     {