Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new async method Response::transmit() replacing Response::transfer() #73

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

thekid
Copy link
Member

@thekid thekid commented Mar 31, 2021

The transfer() method will be deprecated (and then removed at a later point!). Existing code will continue to work, but should be rewritten as follows:

-$response->transfer($file->in(), MimeUtil::getByFileName($file->filename), $file->size());
+yield from $response->transmit($file->in(), MimeUtil::getByFileName($file->filename), $file->size());

See also #72 and #70

@thekid thekid merged commit ad1840b into master Mar 31, 2021
@thekid thekid deleted the feature/transmit branch March 31, 2021 18:30
@thekid
Copy link
Member Author

thekid commented Apr 1, 2021

@thekid thekid mentioned this pull request Aug 24, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant