Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ninja dep to cmake #5222

Merged
merged 3 commits into from
Sep 13, 2024
Merged

add ninja dep to cmake #5222

merged 3 commits into from
Sep 13, 2024

Conversation

waruqi
Copy link
Member

@waruqi waruqi commented Sep 13, 2024

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

on_load(function (package)
-- xmake v3.x will enable this ninja policy by default
import("core.project.project")
if project.policy("package.cmake_generator.ninja") then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use xmake:version():ge("3.0.0")?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用,现在的版本也有 package.cmake_generator.ninja 而且 2.8.3 就已经存在这个了。。只是默认关着而已,不影响。。

还能提前体验和测试这个特性,等 3.0 再默认放开就行了。

@waruqi waruqi merged commit 99fab43 into dev Sep 13, 2024
65 checks passed
@waruqi waruqi deleted the cmake branch September 13, 2024 11:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants