Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: task manager panic in some cases #925

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lxl66566
Copy link
Collaborator

Depends-On: #918
fix #919

@mergify mergify bot requested a review from a team July 29, 2024 16:14
Copy link

mergify bot commented Jul 29, 2024

@lxl66566 Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft July 29, 2024 16:16
@mergify mergify bot added the CI:fail CI has failed label Jul 29, 2024
@lxl66566 lxl66566 force-pushed the panic-fix branch 2 times, most recently from 7418d9f to 7c29d0a Compare July 30, 2024 01:02
@mergify mergify bot marked this pull request as ready for review July 30, 2024 01:12
@mergify mergify bot removed the CI:fail CI has failed label Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.09%. Comparing base (e35b35a) to head (7c29d0a).
Report is 297 commits behind head on master.

Files with missing lines Patch % Lines
crates/utils/src/task_manager/tasks.rs 0.00% 4 Missing ⚠️
crates/utils/src/task_manager/mod.rs 91.66% 0 Missing and 2 partials ⚠️
crates/xline/src/server/lease_server.rs 50.00% 0 Missing and 2 partials ⚠️
crates/xline/src/server/watch_server.rs 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
+ Coverage   75.55%   76.09%   +0.53%     
==========================================
  Files         180      189       +9     
  Lines       26938    28855    +1917     
  Branches    26938    28855    +1917     
==========================================
+ Hits        20353    21957    +1604     
- Misses       5366     5557     +191     
- Partials     1219     1341     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the Stale label Aug 30, 2024
Copy link

mergify bot commented Aug 30, 2024

@lxl66566 Your PR is in conflict and cannot be merged.

@github-actions github-actions bot removed the Stale label Aug 31, 2024
Signed-off-by: lxl66566 <lxl66566@gmail.com>
Signed-off-by: lxl66566 <lxl66566@gmail.com>
Copy link

mergify bot commented Sep 20, 2024

@lxl66566 Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft September 20, 2024 07:32
@mergify mergify bot added the CI:fail CI has failed label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI:fail CI has failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: task manager panic
1 participant