Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add txn retry logic #776

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

Phoenix500526
Copy link
Collaborator

@Phoenix500526 Phoenix500526 commented Apr 12, 2024

Refs: #774
Closes: #774

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    FYI: [Bug]: The test case curp::it server::shutdown_rpc_should_shutdown_the_cluster failed #774

  • what changes does this pull request make?
    Add a retry logic in write_batch.

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    There is nothing to change breakingly, but we need to do a performance regression test for this modification.

Closes: xline-kv#774
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
@Phoenix500526 Phoenix500526 force-pushed the fix/issue-774 branch 2 times, most recently from 7f93597 to 9567c0d Compare April 12, 2024 06:21
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 57.98319% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 75.59%. Comparing base (e35b35a) to head (8f4f038).
Report is 14 commits behind head on master.

❗ Current head 8f4f038 differs from pull request most recent head ebda1ef. Consider uploading reports for the commit ebda1ef to get more accurate results

Files Patch % Lines
crates/xline/src/utils/args.rs 0.00% 18 Missing ⚠️
crates/engine/src/rocksdb_engine/mod.rs 84.21% 3 Missing and 6 partials ⚠️
crates/curp/src/server/curp_node.rs 0.00% 5 Missing ⚠️
crates/xlinectl/src/command/watch.rs 0.00% 5 Missing ⚠️
crates/xline/src/storage/auth_store/store.rs 20.00% 4 Missing ⚠️
crates/xline/src/storage/lease_store/mod.rs 50.00% 2 Missing ⚠️
crates/curp-test-utils/src/test_cmd.rs 80.00% 0 Missing and 1 partial ⚠️
crates/curp/src/server/cmd_worker/mod.rs 0.00% 1 Missing ⚠️
crates/xline-client/src/clients/auth.rs 75.00% 0 Missing and 1 partial ⚠️
crates/xline-client/src/clients/kv.rs 75.00% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
+ Coverage   75.55%   75.59%   +0.04%     
==========================================
  Files         180      182       +2     
  Lines       26938    27056     +118     
  Branches    26938    27056     +118     
==========================================
+ Hits        20353    20454     +101     
- Misses       5366     5385      +19     
+ Partials     1219     1217       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
@Phoenix500526 Phoenix500526 merged commit b1744f2 into xline-kv:master Apr 18, 2024
12 checks passed
@Phoenix500526 Phoenix500526 deleted the fix/issue-774 branch April 18, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The test case curp::it server::shutdown_rpc_should_shutdown_the_cluster failed
3 participants