Refactor: Test Framework and Update Docker Compose Configuration #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rohansx <sharmarohan615@gmail.com>
Signed-off-by: ChaudharyRaman <ramanchaudhary2704@gmail.com> Signed-off-by: rohansx <sharmarohan615@gmail.com>
1 task
There was a problem hiding this comment.
Thank you for your contribution. These commit messages don't meet the conventional requirement outlined in our CONTRIBUTING doc. Please revise them and add signed-off-by statements. Additionally, please rebase this pr.
scripts/validation_test.sh
Outdated
Comment on lines
2
to
8
| <<<<<<< HEAD | ||
| ======= | ||
| DIR="$(dirname $0)" | ||
| QUICK_START="${DIR}/quick_start.sh" | ||
| ETCDCTL="docker exec -i client etcdctl --endpoints=http://172.20.0.3:2379,http://172.20.0.4:2379" | ||
| LOCK_CLIENT="docker exec -i client /mnt/validation_lock_client --endpoints=http://172.20.0.3:2379,http://172.20.0.4:2379,http://172.20.0.5:2379" | ||
| >>>>>>> ef29834 (chore: mount LOG_PATH as xline container log dir) |
There was a problem hiding this comment.
Please iron out the code conflict here.
scripts/validation_test.sh
Outdated
Comment on lines
14
to
17
| <<<<<<< HEAD | ||
| # Source log functions | ||
| source "${DIR}/log.sh" | ||
| ======= |
scripts/validation_test.sh
Outdated
| run_validation_tests() { | ||
| # Example validation test | ||
| log::info "Starting validation tests..." | ||
|
|
There was a problem hiding this comment.
Please remove the trailing space in this line.
scripts/validation_test.sh
Outdated
| # Add your validation logic here, for example: | ||
| # 1. Check if services are healthy | ||
| # 2. Execute specific commands against your services | ||
|
|
Signed-off-by: rohansx <sharmarohan615@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes:
docker-compose.ymlfile to manage the Xline cluster configuration, ensuring all services are correctly networked and equipped with the necessary volumes, ports, and environment settings.validation.shscript to utilize Docker Compose for starting and stopping services, aligning it with the new docker-compose.yml configuration. This update simplifies the validation process and ensures compatibility with the Docker Compose setup.benchmark.shandquick_start.shdocumentation to reflect the new Docker Compose-based approach. This includes instructions on how to use the docker-compose file for setting up a development or testing environment and guidelines for executing validation and benchmark tests.These changes aim to streamline the project's testing framework, reduce redundancy, and improve the overall developer experience when testing and validating the Xline cluster's functionality.
Resolves: #692