Codecov/fluctuation #340
Merged
Codecov/fluctuation #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phoenix500526
force-pushed
the
codecov/fluctuation
branch
from
2776293
to
5a91eda
Compare
Phoenix500526
requested review from
themanforfree,
bsbds and
rogercloud
and removed request for
themanforfree
This was
linked to
issues
Jun 21, 2023
Phoenix500526
force-pushed
the
codecov/fluctuation
branch
2 times, most recently
from
06c9cc8
to
c7a40b9
Compare
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
+ Coverage 54.42% 54.58% +0.16%
==========================================
Files 89 89
Lines 12822 12865 +43
Branches 12822 12865 +43
==========================================
+ Hits 6979 7023 +44
Misses 5392 5392
+ Partials 451 450 -1
|
…n the notify method Refs: 338
… together Refs: xline-kv#338, xline-kv#339 Closes: xline-kv#338, xline-kv#339
Phoenix500526
force-pushed
the
codecov/fluctuation
branch
from
c7a40b9
to
03c8fc1
Compare
bsbds
reviewed
Jun 25, 2023
themanforfree
approved these changes
Jun 25, 2023
iGxnon
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
Add some test cases to cover some code branch determinism.
Fix bug [Bug]: EventListener will lose event since it's not cancellation safe. #339 and add a test
test_watch_task_should_be_terminated_when_response_tx_is_closedto cover it.are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No