Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shenyu-common into the openctest framework #14

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

KobeNorris
Copy link

@KobeNorris KobeNorris commented Nov 30, 2022

Details

In order to make openctest applicable to project Shen Yu, I did the following changes to the framework.

  1. Additions (Files that are newly added to the framework):
  2. Modification (Files that are modified in the framework):
  3. Non-trival changes (Huge change to the code logic):
    • runner.py : The self.setInTest is always false, and it does not work with hadoop common project as well, so I commented it out.
    • main.py : The mapping[param] with always crash the entire code if param could not be found in the opensource-shenyu-common.json file, so I add param in mapping.keys() and before to avoid crashing.

@KobeNorris KobeNorris changed the title Adding Shen Yu into the openctest framework Adding shenyu-common into the openctest framework Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant