-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies which do not bump minimum rustc #3359
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3359 +/- ##
==========================================
+ Coverage 88.52% 88.54% +0.01%
==========================================
Files 89 89
Lines 28323 28355 +32
==========================================
+ Hits 25074 25107 +33
+ Misses 3249 3248 -1 ☔ View full report in Codecov by Sentry. |
Cargo.lock
Outdated
@@ -251,15 +260,15 @@ dependencies = [ | |||
|
|||
[[package]] | |||
name = "bumpalo" | |||
version = "3.14.0" | |||
version = "3.15.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the WASM build. Bumpalo 3.15.0 changed the MSRV to 1.73.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be really happy if more Rust maintainers would consider a compiler version change as breaking... anyway I guess I'll add a CI step for wasm, looks like we're missing them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSRV bump being considered semver breaking or not seems to be a very contentious issue..
It would be a lot better if cargo update honored the MSRV, I think a lot of issues would be inherently solved by that
BTW I recommend using cargo-hack to validate MSRV (and other things): Might be worth adding something to CI, although a job like that would take very long to complete... |
We do have CI jobs for validating minimum rust version. Just not one for wasm currently. hack might be useful for local testing before pushing up to CI. |
0be80a3
to
29f9e4f
Compare
It looks like adding wasm tests in CI here may be a bit more complicated than in v_frame. But I'm also not an expert at Github actions. Anyway, for now I'll create an issue to follow up on adding wasm tests to CI, so we don't forget it. |
29f9e4f
to
025a405
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to build fine on 1.70 now.
On second thought, maybe add a comment in the Cargo.toml that clap is held back for MSRV reasons? |
It should be freshened and landed... Somehow the notification got lost. |
025a405
to
d3e7f9b
Compare
d3e7f9b
to
e1db3b7
Compare
Meh, let's bump to 1.74 and be done with that :) |
No description provided.