Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generics for bit depth throughout the encoder #3121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use generics for bit depth throughout the encoder #3121

wants to merge 2 commits into from

Commits on Jan 30, 2023

  1. Use generics for bit depth throughout the encoder 

    This is a followup from xiph#3116 which expands this optimization
to as many places in the encoder as we can reasonably utilize it.
By using generics, there are places where the compiler is able to
simplify math operations at compile time as well as areas where the
compiler is able to remove branches so that we only branch on bit depth
at the highest level of the code (and therefore the fewest number of
times).

Based on hyperfine benchmarking, this results in a 1-2% speedup across
the encoding process, although it does increase the final binary size.
    @shssoichiro
    shssoichiro committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    cf61536 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Fix tests

    @shssoichiro
    shssoichiro committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    ee64e55 View commit details
    Browse the repository at this point in the history