Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor internals #2689

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Refactor internals #2689

wants to merge 5 commits into from

Conversation

lu-zero
Copy link
Collaborator

@lu-zero lu-zero commented Mar 12, 2021 •
edited

Speed neutral according to a test run on echidna.

@lu-zero lu-zero requested a review from YaLTeR March 12, 2021 15:06
@coveralls
Copy link
Collaborator

coveralls commented Mar 12, 2021 •
edited

Coverage Status

Coverage decreased (-0.01%) to 83.209% when pulling 53fc05b on rust-av:refactor-internals into 5117d9f on xiph:master.

@lu-zero lu-zero force-pushed the refactor-internals branch 7 times, most recently from 8052aa4 to ea5daae Compare March 17, 2021 17:00
@lu-zero lu-zero requested a review from barrbrain March 29, 2021 17:13
barrbrain
barrbrain approved these changes Mar 30, 2021
View reviewed changes
Copy link
Collaborator

@barrbrain barrbrain left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No externally visible change in behavior and fewer paths where fi.invalid is true. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barrbrain barrbrain barrbrain approved these changes

@YaLTeR YaLTeR Awaiting requested review from YaLTeR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lu-zero @coveralls @barrbrain