-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make C API installation instructions usable #2677
base: master
Are you sure you want to change the base?
Conversation
The Rust toolchain is not installed globally by default, so it is impossible to use Cargo to install a library unless installing another toolchain for root, messing with the root environment so the whole user toolchain can be located, or installing locally and then manually moving the output. This fixes the installation instructions to use the simplest of those solutions.
3d9b691
to
98e1872
Compare
cargo cinstall --release | ||
$ cargo install cargo-c | ||
$ cargo cinstall --destdir=$HOME/librav1e --release | ||
# mv $HOME/librav1e/* / && rmdir $HOME/librav1e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sudo might be mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using mv like this won't yield correct permissions unfortunately.
We could just suggest an install into ~/.local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The canonical way to copy with correct permissions is /usr/bin/install, but it unfortunately can't copy recursively.
I had some incantation that made cinstall work as well but I can't find it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#
implies root, on my end moving the files with sudo seemed to set the owner to root and permissions also seem to match other libraries. I didn't run exactly those lines though but I also didn't change permissions or owner manually.
Suggesting a local installation seems okay to me though.
The Rust toolchain is not installed globally by default, so it is impossible to use
Cargo to install a library unless installing another toolchain for root, messing with
the root environment so the whole user toolchain can be located, or installing locally
and then manually moving the output. This fixes the installation instructions to use
the simplest of those solutions, saving most users frustration and manual reading time.