Make C API installation instructions usable #2677
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzumer
changed the title
The Rust toolchain is not installed globally by default, so it is impossible to use Cargo to install a library unless installing another toolchain for root, messing with the root environment so the whole user toolchain can be located, or installing locally and then manually moving the output. This fixes the installation instructions to use the simplest of those solutions.
rzumer
force-pushed
the
rzumer-patch-3
branch
from
3d9b691
to
98e1872
Compare
lu-zero
reviewed
Feb 25, 2021
| cargo cinstall --release | ||
| $ cargo install cargo-c | ||
| $ cargo cinstall --destdir=$HOME/librav1e --release | ||
| # mv $HOME/librav1e/* / && rmdir $HOME/librav1e |
There was a problem hiding this comment.
Using mv like this won't yield correct permissions unfortunately.
We could just suggest an install into ~/.local
There was a problem hiding this comment.
The canonical way to copy with correct permissions is /usr/bin/install, but it unfortunately can't copy recursively.
I had some incantation that made cinstall work as well but I can't find it now.
There was a problem hiding this comment.
# implies root, on my end moving the files with sudo seemed to set the owner to root and permissions also seem to match other libraries. I didn't run exactly those lines though but I also didn't change permissions or owner manually.
Suggesting a local installation seems okay to me though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust toolchain is not installed globally by default, so it is impossible to use
Cargo to install a library unless installing another toolchain for root, messing with
the root environment so the whole user toolchain can be located, or installing locally
and then manually moving the output. This fixes the installation instructions to use
the simplest of those solutions, saving most users frustration and manual reading time.