-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] CDEF parallelization #2657
base: master
Are you sure you want to change the base?
Conversation
src/lib.rs
Outdated
@@ -56,6 +56,7 @@ | |||
#![warn(clippy::needless_continue)] | |||
#![warn(clippy::path_buf_push_overwrite)] | |||
#![warn(clippy::range_plus_one)] | |||
#![feature(type_ascription)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a nightly feature, why do you need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwice tpl: &(usize, usize)
in queue errors.
note: see issue #23416 <https://github.com/rust-lang/rust/issues/23416> for more information
help: add `#![feature(type_ascription)]` to the crate attributes to enablerustc(E0658)
Don't know how to get around that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do not need to do that, rust is not swift :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad)
} | ||
|
||
#[hawktracer(filter_tile)] | ||
pub fn filter_tile<T: Pixel>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please configure your editor to run rustfmt on save.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
src/cdef.rs
Outdated
queue.push((fbx, fby)); | ||
}} | ||
|
||
queue.par_iter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output needs to be part of the queue.
The big issue with the output being accessible by all threads, I don't know a "no pain" way to do this, the probable solution is using spinlock on output |
Hi @master-of-zen, thank you for the patch. We would be happy to have you join and contribute to the project. A lot of coordination and discussion for rav1e happens on freenode IRC in #daala. Feel free to join us there as well. |
159c96e
to
54bddec
Compare
I wish to contribute and join rav1e development in the future, as I'm heavy invested in video encoding/AV1 and currently I'm a rust newbie. I heard that a good starting piece would be CDEF parallelization, and here we begin)
This code tries to use
rayon
's parallel iterator for CDEF parallelization, only issue atm is thatoutput
can't be borrowed as mutable.