Make max_keyframe_interval = 0 an error

xiph · Sep 3, 2019 · 74d90cb · 74d90cb
1 parent 6b9f362
commit 74d90cb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/api/mod.rs b/src/api/mod.rs
@@ -571,6 +571,9 @@ impl Config {
     if config.rdo_lookahead_frames > MAX_RDO_LOOKAHEAD_FRAMES {
       return Err(EncoderStatus::Failure);
     }
+    if config.max_key_frame_interval == 0 {
+      return Err(EncoderStatus::Failure);
+    }
 
     if !check_tile_log2(config.tile_cols) {
       return Err(EncoderStatus::Failure);

diff --git a/src/api/test.rs b/src/api/test.rs
@@ -1662,3 +1662,11 @@ fn log_q_exp_overflow() {
   ctx.receive_packet().unwrap();
   let _ = ctx.receive_packet();
 }
+
+#[test]
+fn max_key_frame_interval_zero() {
+  let mut config = Config::default();
+  config.enc.max_key_frame_interval = 0;
+  let res: Result<Context<u8>, _> = config.new_context();
+  assert!(res.is_err());
+}