Feature/nv 8287 global ignore #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kitaKozlovtcev/spellcheck-microservice into feature/NV-8287-global-ignore
Closed
xfenix
reviewed
Jul 16, 2024
whole_app/settings.py
Outdated
| str, | ||
| pydantic.Field( | ||
| description="list of words which will ignored by default(string separated by comma)", | ||
| ), | ||
| ] = "" | ||
| exclusion_words_set: typing.Annotated[ |
There was a problem hiding this comment.
А зачем две переменных, зачем и стр и сет? В дескрипшене нет объяснений. Стоит так же в доке к каждой переменной указывать example использования.
There was a problem hiding this comment.
Артур просил в прошлом PR строку в переменную окружения, а не список, поэтому я добавил exclusion_words_str и assemble_exclusion_words_set(). Чтобы один раз распарсить строку и получить exclusion_words_set. Примеры значений в переменных добавил и обновил ридми
There was a problem hiding this comment.
обновил описание и ридми как обсудили
…kitaKozlovtcev/spellcheck-microservice into feature/NV-8287-global-ignore
xfenix
reviewed
Jul 16, 2024
README.md
Outdated
| * `SPELLCHECK_EXCLUSION_WORDS` list of words which will ignored by default(string separated by comma). Default value is empty string. | ||
| * `SPELLCHECK_EXCLUSION_WORDS_STR` list of words which will ignored by default(string separated by comma). Example: 'foo, bar'. Default value is empty string. | ||
| * `SPELLCHECK_EXCLUSION_WORDS_SET` set of words which will ignored by default(filled from exclusion_words_str). | ||
| Example: '["foo", "bar"]' . Default value is `set()`. |
There was a problem hiding this comment.
Example: ["foo", "bar"]
Стоит использовать символ `
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #25