Fix hard coded Sonatype URL #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steinybot Thanks. I've modified the PR to simply the setting for users. |
steinybot
commented
Mar 11, 2021
| > | ||
| > ```scala | ||
| > // For all Sonatype accounts created on or after February 2021 | ||
| > ThisBuild / sonatypeCredentialHost := "s01.oss.sonatype.org" |
There was a problem hiding this comment.
This should probably be:
Suggested change
| > ThisBuild / sonatypeCredentialHost := "s01.oss.sonatype.org" | |
| > ThisBuild / sonatypeCredentialHost := Sonatype.sonatype01 |
There was a problem hiding this comment.
@xerial I was a bit too late with this comment but FYI.
There was a problem hiding this comment.
Yeah. I added this constant because I thought it can be used like that, but using "s01.oss.sonatype.org" would be more straightforward for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the workaround for #214 although doesn't fix that issue completely.
In order to support both Sonatype URLs I think this ought to first try
oss.sonatype.organd then fallback tos01.oss.sonatype.org.In any case it should still be possible to override the URL manually which this PR enables.