Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle art errors gracefully for 2019 models #120

Merged
merged 1 commit into from
May 2, 2023
Merged

Handle art errors gracefully for 2019 models #120

merged 1 commit into from
May 2, 2023

Conversation

thypon
Copy link
Contributor

@thypon thypon commented May 2, 2023

required for 2019 samsung models

@thypon
Copy link
Contributor Author

thypon commented May 2, 2023

Re: #106

@thypon thypon mentioned this pull request May 2, 2023
Open
@epenet
Copy link
Collaborator

epenet commented May 2, 2023

Could you add a test to tests/test_art.py ?

@thypon
Copy link
Contributor Author

thypon commented May 2, 2023

How you start the test-suite here?

@epenet
Copy link
Collaborator

epenet commented May 2, 2023

On your machine: pytest tests/test_art.py
On the CI: this is your first contribution on this repository, so the maintainer needs to run it manually.

@thypon
Copy link
Contributor Author

thypon commented May 2, 2023

Will create a test for a working condition, right now it's just exiting gracefully on error.
Feel free to merge when it will be a full Samsung 2019 fix.

I discovered another bug on the firmware 14xx (the last available on 2019 models).
get_matte_list is not working since it's searching for matte_type_list and not matte_list which seems the key available on these firmwares.

epenet
epenet requested changes May 2, 2023
View reviewed changes
samsungtvws/art.py Outdated Show resolved Hide resolved
samsungtvws/art.py Outdated Show resolved Hide resolved
samsungtvws/art.py Outdated Show resolved Hide resolved
@thypon
art.py: handle errors gracefully
81f231a 
required for 2019 samsung models
@epenet epenet changed the title art.py: handle errors gracefully Handle art errors gracefully for 2019 models May 2, 2023
epenet
epenet approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
We can add tests in a follow-up PR.

@epenet epenet merged commit f51335a into xchwarze:master May 2, 2023
@epenet epenet mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epenet epenet epenet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thypon @epenet