Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome extension now requires "read and change all your data on the websites you visit". #43

Closed
hrez opened this issue Oct 16, 2018 · 5 comments
Assignees

Comments

@hrez
Copy link

hrez commented Oct 16, 2018

Chrome extension now requires "read and change all your data on the websites you visit".
What's the reason for this new permission?
Can it be re-deployed without this permission to be a requirement?

Client app information

extension version: 1.4.0
source: Chrome Web Store
Chrome Version 69.0.3497.100 (Official Build) (64-bit)

@nero120 nero120 self-assigned this Oct 21, 2018
@nero120
Copy link
Member

nero120 commented Oct 21, 2018

Hi @hrez, yes this may be possible but I need to do some testing to confirm. Will look into it for the next version.

@hrez
Copy link
Author

hrez commented Oct 22, 2018

Hi, looking forward, thanks.
FYI, check out https://chrome.google.com/webstore/detail/xbrowsersync/lcbjdhceifofjlpecfpeimnnphbcjgnc support on the same topic in case you are not aware.

@nero120
Copy link
Member

nero120 commented Oct 31, 2018

Thanks @hrez.

I've had a chance to do some testing and unfortunately I can't get around requesting this permission. The reason is that in order to automatically add HTML page metadata when the user clicks the native "Add Bookmark" button, the background script must be able to call tabs.executeScript against the page, which it can only do if the page's URL has been added to the manifest permissions. And, as this can happen on any page (i.e. any URL), the extension must have the <all_urls> permission which is displayed to the user as "read and change all your data on the websites you visit".

The only place this permission is required is in the desktop browser platform implementation getPageMetadata function (e.g. here for Chrome).

I'm therefore going to close this issue, please respond back if you have any further questions.

@nero120 nero120 closed this as completed Oct 31, 2018
@nero120 nero120 added this to the v1.4.1 milestone Feb 21, 2019
@nero120
Copy link
Member

nero120 commented Feb 21, 2019

@hrez I managed to find a workaround so the next version (v1.4.1) will no longer require the "read and change all your data on the websites you visit" permission.

@nero120 nero120 reopened this Feb 21, 2019
@hrez
Copy link
Author

hrez commented Feb 21, 2019

Thanks @nero120
Appreciate all the effort.

nero120 added a commit that referenced this issue Mar 6, 2019
…ox bug currently prevents implementation) (#43).

Added permissions management to Settings panel.
Updated get metadata content script to execute on demand rather than on every page.
Added additional logging.
Styling updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants