-
Notifications
You must be signed in to change notification settings - Fork 15
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G17 Support / Default OrcaSlicer Profile #48
Comments
I already tested it in my own version by patching klipper like you suggested before by updating the zhop code path from the mainline version. It works as far as I can tell. |
Great, I had no idea! |
Hasn't been merged yet ;) Just for testing and getting rid of the annoying messages. I think we should discuss patches when the structure is more clear. Currently klipper is a submodule with already one patch applied. Maybe that's the way to go or we take a different approach. Preferably of course FF updates to klipper v12 so we can use mainline. |
If we want this to be patched, we need the proper patches reflecting the upstream changes I want to move away from the forked repos such as Klipper/Buildroot and have everything integrated in the main repo. We can then maintain a set of patches to 0.11 with quilt. Or maybe Klipper could also become a Buildroot package instead of doing everything in post build, but haven't though enough about this yet. About the warnings: Is this configured wrong in the default Orca Slicer profile for ADM5 as well? Since Klipper 0.11 doesn't support it I would assume it's disabled in the default profiles. |
@xblax from what I can recall yes. I started my configuration from the original flashforge profiles, but I cannot recall if they were shipped with my specific version of OrcaSlicer or if I had them downloaded from their website. In theory G17 has no effect unless the plane was changed before with another command in the series, so even if it appears in the original firmware, they might not care. |
The 2.x.dev version which supports the flashforge network integration does it at least. |
This has been integrated in the main branch |
Originally posted by @KaruroChori in #36 (comment)
I added few lines to comment this issue in the docs, so that it is not a problem for release.
Ideally, either we patch support for it in, or we ensure profiles do not use the spiral z-hop path.
The text was updated successfully, but these errors were encountered: