Skip to content

Commit

Permalink
feat(ecs-patterns): dualstack ALB (aws#30089)
Browse files Browse the repository at this point in the history
### Issue # (if applicable)

Closes aws#29039.

### Reason for this change

Both `ApplicationLoadBalancedFargateService` and `ApplicationLoadBalancedEc2Service` don't support specifying dualstack ALB.

### Description of changes

Added `ipAddressType` to `ApplicationLoadBalancedServiceBaseProps`.

### Description of how you validated changes

Added both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
badmintoncryer authored and xazhao committed Sep 12, 2024
1 parent 6865f15 commit 49c6cd3
Show file tree
Hide file tree
Showing 22 changed files with 35,698 additions and 207 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -889,6 +889,7 @@
"myServiceLB168895E1": {
"Type": "AWS::ElasticLoadBalancingV2::LoadBalancer",
"Properties": {
"IpAddressType": "ipv4",
"LoadBalancerAttributes": [
{
"Key": "deletion_protection.enabled",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 49c6cd3

Please sign in to comment.