-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono-2018-10] add build rules for arm64_32 watch #5439
Conversation
$(Q) $(WATCHOS_BIN_PATH)/bitcode_strip $(WATCHOS_TARGET_SHAREDLIBLOGPROFILER) -m -o $@ | ||
$(Q) $(WATCHOS_BIN_PATH)/install_name_tool -id @rpath/libmono-profiler-log.dylib -change $(SDK_DESTDIR)/ios-targetwatch-release/lib/libmonosgen-2.0.1.dylib @rpath/libmonosgen-2.0.dylib $@ | ||
$(Q) $(WATCHOS_BIN_PATH)/bitcode_strip $(BUILD_DESTDIR)/targetwatch/lib/libmono-profiler-log.0.dylib -m -o $(BUILD_DESTDIR)/targetwatch/tmp-lib/libmono-profiler-log.0.dylib | ||
$(Q) $(WATCHOS_BIN_PATH)/bitcode_strip $(BUILD_DESTDIR)/targetwatch64_32/lib/libmono-profiler-log.0.dylib -m -o $(BUILD_DESTDIR)/targetwatch64_32/tmp-lib/libmono-profiler-log.0.dylib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rolfbjarne do you have a suggestion to make that a bit nicer?
Build failure |
Build failure Test results9 tests failed, 0 tests skipped, 129 tests passed.Failed tests
|
Build failure 🔥 Build failed 🔥 |
Build failure |
IMO this work should be based on (not in) Right now if we need a quick release (even a preview) to support this new architecture we would be blocking ourselves (and our customers) on completing mono |
Following Slack discussion (https://xamarinhq.slack.com/archives/C03CFKFGL/p1548259145038500) a custom |
superseded by #5465 |
NOTE1: tested with this hacky patch for xharness: https://gist.github.com/lewurm/b4243bad2b4407bdd7f056bbdbeafd5b
NOTE2: depends on mono/mono#12498merged ✅In terms of
mono-native*
the handling for the new watch is a bit different, due to watchOS 5.0 doesn't require compat/unified as far as I understand.Verified by running mini regression suite. It's green 🙂
Context: mono/mono#10641