[xcode13.3] Bring Xcode 13.3 support #14325

dalexsoto · 2022-03-07T02:49:17Z

This PR brings Xcode 13.3 support up to Beta 3.

Probably better reviewed commit by commit.

Ignoring CHIP framework for now since it is not stable just yet and we want to avoid breaking changes in the future.

We can update it once xamarin#14303 lands

vs-mobiletools-engineering-service2 · 2022-03-07T04:32:45Z

❌ [PR Build] Tests didn't execute on Build. ❌

Tests didn't execute on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops
macOS vsdrops
tvOS vsdrops
watchOS vsdrops

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

API Current PR diff

View API diff

iOS vsdrops
macOS vsdrops
tvOS vsdrops
watchOS vsdrops

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

⚠️ Generator diff comments have not been provided.

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

No test summary was found (something probably failed before the tests could execute)

Pipeline on Agent
Merge b91411c into e5f7cd7

vs-mobiletools-engineering-service2 · 2022-03-07T05:21:32Z

❌ [PR Build] Tests didn't execute on Build. ❌

Tests didn't execute on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops
macOS vsdrops
tvOS vsdrops
watchOS vsdrops

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

API Current PR diff

View API diff

iOS vsdrops
macOS vsdrops
tvOS vsdrops
watchOS vsdrops

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

⚠️ Generator diff comments have not been provided.

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

No test summary was found (something probably failed before the tests could execute)

Pipeline on Agent
Merge b91411c into e5f7cd7

rolfbjarne

Looks good, only missing tests for the manual bindings :)

rolfbjarne · 2022-03-07T07:16:24Z

Versions-ios.plist.in

@@ -48,6 +48,7 @@
 			<string>14.5</string>
 			<string>15.0</string>
 			<string>15.2</string>
+			<string>15.4</string>


What happened to 15.3?

No idea, what is shipped on Xcode 13.3 is 15.4 I wonder if they are moving to even numbers releases just like us, it seems that there is not 15.1 either heh

rolfbjarne · 2022-03-07T07:21:23Z

src/GameController/GCMotion.cs

+			if (values is null)
+				ObjCRuntime.ThrowHelper.ThrowArgumentNullException (nameof (values));
+			if (values.Length > DiscretePositionCount)
+				throw new ArgumentException ($"The '{nameof (values)}' array length can't be greater than {DiscretePositionCount}.");


Can it be less that DiscretePositionCount?

same, lets use https://docs.microsoft.com/en-us/dotnet/api/system.argumentoutofrangeexception?view=net-6.0

vs-mobiletools-engineering-service2 · 2022-03-07T13:39:34Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops
macOS vsdrops
tvOS vsdrops
watchOS vsdrops

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

API Current PR diff

View API diff

iOS vsdrops
macOS vsdrops
tvOS vsdrops
watchOS vsdrops

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

⚠️ Generator diff comments have not been provided.

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

5 tests failed, 149 tests passed.

Failed tests

xammac tests/Mac Modern/Debug: Failed (Test run failed.
Tests run: 2640 Passed: 2556 Inconclusive: 10 Failed: 1 Ignored: 83)
xammac tests/Mac Modern/Release: Failed (Test run failed.
Tests run: 2637 Passed: 2552 Inconclusive: 10 Failed: 1 Ignored: 84)
monotouch-test/tvOS - simulator/Release (all optimizations) [dotnet]: Failed
MTouch tests/NUnit: Failed (Execution failed with exit code 3)
DotNet tests: Failed (Execution failed with exit code 1)

Pipeline on Agent XAMBOT-1042.Monterey'
Merge 1a0d1cd into e5f7cd7

tj-devel709 · 2022-03-07T15:00:00Z

src/healthkit.cs

+	[Watch (8,5), iOS (15,4), MacCatalyst (15,4)]
+	public enum HKVerifiableClinicalRecordSourceType {
+		[DefaultEnumValue]
+		[Field (null)]


mandel-macaque

Small nits to be fixe before landing, yet it looks good.

mandel-macaque · 2022-03-07T16:47:46Z

src/GameController/GCMotion.cs

+			if (values is null)
+				ObjCRuntime.ThrowHelper.ThrowArgumentNullException (nameof (values));
+			if (values.Length > DiscretePositionCount)
+				throw new ArgumentException ($"The '{nameof (values)}' array length can't be greater than {DiscretePositionCount}.");


https://docs.microsoft.com/en-us/dotnet/api/system.argumentoutofrangeexception?view=net-6.0 is a nicer exception in this case.

mandel-macaque · 2022-03-07T16:47:57Z

src/GameController/GCMotion.cs

+			if (values is null)
+				ObjCRuntime.ThrowHelper.ThrowArgumentNullException (nameof (values));
+			if (values.Length > DiscretePositionCount)
+				throw new ArgumentException ($"The '{nameof (values)}' array length can't be greater than {DiscretePositionCount}.");


same, lets use https://docs.microsoft.com/en-us/dotnet/api/system.argumentoutofrangeexception?view=net-6.0

mandel-macaque · 2022-03-07T16:48:53Z

src/avfoundation.cs

+		[NoWatch]
+		[NoTV, NoMac, MacCatalyst (15,4), iOS (15,4)]


Why is NoWatch in the same line (curious more than anything).

Just to follow along the style in the file, see methods above

mandel-macaque · 2022-03-07T16:52:11Z

src/healthkit.cs

+
+		[iOS (15,4)]
+		[Export ("initWithRecordTypes:sourceTypes:predicate:resultsHandler:")]
+		IntPtr Constructor (string [] recordTypes, [BindAs (typeof (HKVerifiableClinicalRecordSourceType []))] NSString [] sourceTypes, [NullAllowed] NSPredicate predicate, Action<HKVerifiableClinicalRecordQuery, HKVerifiableClinicalRecord [], NSError> resultsHandler);


Lets use a delegate for such a large action, two params and an error.

mandel-macaque

Changing the review because we are missing nullable values here:

Action<HKVerifiableClinicalRecordQuery, HKVerifiableClinicalRecord []?, NSError?>

dalexsoto · 2022-03-14T01:21:29Z

Bringing in another PR

dalexsoto added 30 commits March 6, 2022 18:40

[Xcode 13.3] Initial commit to Xcode 13.3 release

25d3ba4

[xtro] Fix xtro annotations

fab5142

Ignoring CHIP framework for now since it is not stable just yet and we want to avoid breaking changes in the future.

[tests] Fix introspection tests for Xcode 13.3

d6445e2

[Accessibility] Update bindings up to Xcode 13.3 Beta 3

c2f75b8

[AppKit] Update xtro annotations of unbound API

d6c16f3

[AuthenticationServices] Update bindings up to Xcode 13.3 Beta 3

5cdd265

[AVFoundation] Update bindings up to Xcode 13.3 Beta 3

6e92117

[CarPlay] Update bindings up to Xcode 13.3 Beta 3

64008a4

[CellularDataDiagnosticsSuite] Wait to bind this new one until GA

5f26b21

[Contacts] Update bindings up to Xcode 13.3 Beta 3

cbdf3c6

[CoreMediaIO] Add new macOS framework to todo

785577a

[CoreMotion] Update bindings up to Xcode 13.3 Beta 3

3cabb7c

[FileProvider] Update bindings up to Xcode 13.3 Beta 3

2864ae2

[GameController] Update bindings up to Xcode 13.3 Beta 3

da193b1

[HealthKit] Update bindings up to Xcode 13.3 Beta 3

1659839

[HomeKit] Update bindings up to Xcode 13.3 Beta 3

bc88863

[Intents] Update bindings up to Xcode 13.3 Beta 3

e8d7cc8

[MediaSetup] Add MacCat framework to the todo list

de294bb

[MetalPerformanceShadersGraph] Add Framework to todo

3d65404

We can update it once xamarin#14303 lands

[Network] Add Framework to todo

e463927

[PassKit] Update bindings up to Xcode 13.3 Beta 3

a544459

[Photos] Update bindings up to Xcode 13.3 Beta 3

1244854

[ProximityReader] Ignoring this framework nothing useful to bind

c44a90f

[ReplayKit] Update bindings up to Xcode 13.3 Beta 3

6400f98

[ScreenCaptureKit] Add new Framework to todo

c9a1253

[SensorKit] Update bindings up to Xcode 13.3 Beta 3

784e1df

[StoreKit] Update bindings up to Xcode 13.3 Beta 3

0ff8e3a

[UIKit] Update bindings up to Xcode 13.3 Beta 3

3ebf2b6

[VideoToolbox] Update bindings up to Xcode 13.3 Beta 3

da1e8b7

[WebKit] Update bindings up to Xcode 13.3 Beta 3

b91411c

dalexsoto added the note-highlight Worth calling out specifically in release notes label Mar 7, 2022

dalexsoto added this to the xcode13.3 milestone Mar 7, 2022

dalexsoto requested review from rolfbjarne and mandel-macaque as code owners March 7, 2022 02:49

[CI] Force Monterey bot

1a0d1cd

rolfbjarne requested changes Mar 7, 2022

View reviewed changes

tj-devel709 reviewed Mar 7, 2022

View reviewed changes

tj-devel709 approved these changes Mar 7, 2022

View reviewed changes

mandel-macaque approved these changes Mar 7, 2022

View reviewed changes

mandel-macaque requested changes Mar 7, 2022

View reviewed changes

dalexsoto closed this Mar 14, 2022

dalexsoto mentioned this pull request Mar 15, 2022

[xcode13.3] Update bindings to Xcode 13.3 #14415

Merged

MFinkBK mentioned this pull request Mar 30, 2022

iOS 15.4 - Xamarin.iOS - Crash when scanning with AVCaptureEngine Redth/ZXing.Net.Mobile#1035

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[xcode13.3] Bring Xcode 13.3 support #14325

[xcode13.3] Bring Xcode 13.3 support #14325

dalexsoto commented Mar 7, 2022

vs-mobiletools-engineering-service2 commented Mar 7, 2022

vs-mobiletools-engineering-service2 commented Mar 7, 2022

rolfbjarne left a comment

rolfbjarne Mar 7, 2022

dalexsoto Mar 7, 2022

rolfbjarne Mar 7, 2022

mandel-macaque Mar 7, 2022

vs-mobiletools-engineering-service2 commented Mar 7, 2022

Failed tests

tj-devel709 Mar 7, 2022

mandel-macaque left a comment

mandel-macaque Mar 7, 2022

mandel-macaque Mar 7, 2022

mandel-macaque Mar 7, 2022

dalexsoto Mar 12, 2022

mandel-macaque Mar 7, 2022

mandel-macaque left a comment

dalexsoto commented Mar 14, 2022

[xcode13.3] Bring Xcode 13.3 support #14325

[xcode13.3] Bring Xcode 13.3 support #14325

Conversation

dalexsoto commented Mar 7, 2022

vs-mobiletools-engineering-service2 commented Mar 7, 2022

❌ [PR Build] Tests didn't execute on Build. ❌

API diff

API Current PR diff

GitHub pages

vs-mobiletools-engineering-service2 commented Mar 7, 2022

❌ [PR Build] Tests didn't execute on Build. ❌

API diff

API Current PR diff

GitHub pages

rolfbjarne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Mar 7, 2022

❌ [PR Build] Tests failed on Build ❌

API diff

API Current PR diff

GitHub pages

Test results

Failed tests

Choose a reason for hiding this comment

mandel-macaque left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mandel-macaque left a comment

Choose a reason for hiding this comment

dalexsoto commented Mar 14, 2022