Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Carplay] Add support for Xcode 13 beta 5 and fix catalyst attrs. #12454

Merged
merged 2 commits into from
Aug 17, 2021
Merged

[Carplay] Add support for Xcode 13 beta 5 and fix catalyst attrs. #12454

merged 2 commits into from
Aug 17, 2021

Conversation

mandel-macaque
Copy link
Member

No description provided.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Aug 16, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 101 tests passed.

Failed tests

  • xammac tests/Mac Modern/Release: Failed (Test run failed.
    Tests run: 2469 Passed: 2403 Inconclusive: 10 Failed: 1 Ignored: 65)

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 722490a into 3af0e34

@mandel-macaque
Copy link
Member Author

Failure is not related: https://github.com/xamarin/maccore/issues/2493

spouliot
spouliot suggested changes Aug 17, 2021
View reviewed changes
src/carplay.cs

[NoWatch, NoTV, NoMac, iOS (15,0), MacCatalyst (15,0)]
[BaseType (typeof(NSObject))]
interface CPAssistantCellConfiguration : NSSecureCoding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> [DisableDefaultCtor]
there's no way to change the default, empty/null, value if init is used - so it's unusable

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 102 tests passed 🎉

Pipeline on Agent XAMBOT-1104.BigSur
Merge ab90775 into 08eaaf9

@mandel-macaque mandel-macaque merged commit 0b01c40 into xamarin:main Aug 17, 2021
@mandel-macaque mandel-macaque deleted the carplay-xcode13-bet5 branch August 17, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@spouliot spouliot spouliot approved these changes

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mandel-macaque @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @spouliot