Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HomeKit] Updates for Xcode13 Beta 5 #12451

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

tj-devel709
Copy link
Contributor

Not 100% sure if this is correct.
The headers showed that they are now deprecated, but Sharpie and the web docs do not reflect this.
I will test in Xcode to be sure!

@tj-devel709 tj-devel709 added the note-highlight Worth calling out specifically in release notes label Aug 16, 2021
@tj-devel709 tj-devel709 added this to the xcode13.0 milestone Aug 16, 2021
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the headers, it is correct.

Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why sharpie did not pick it up. Likely because the macro is different from others (each framework like to have it's own or re-define them) and did not end up inside the .pch file.

In any case the attributes will not cause a breaking change if we have to update them later, so having them in sync with Xcode headers is fine :-)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 101 tests passed.

Failed tests

  • monotouch-test/tvOS - simulator/Debug (LinkSdk): Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 0fa43c6 into b4e828c

@mandel-macaque
Copy link
Member

The failing tests is a network one, we have been having several of those in the CI in recent days:

TestNSUrlSessionHandlerCookies : Failed to get native cookies 

@mandel-macaque mandel-macaque merged commit 2ae518e into xamarin:main Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants