Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIP] Add support for Xcode13 beta2. #12025

Merged
merged 19 commits into from
Jul 1, 2021

Conversation

mandel-macaque
Copy link
Member

No description provided.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Jun 25, 2021
src/chip.cs Outdated Show resolved Hide resolved
[DesignatedInitializer]
IntPtr Constructor (ChipDevice device, byte endpoint, DispatchQueue queue);

[Async (ResultTypeName = "ChipReadAttributeResult")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When should we use this ResultTypeName with Async?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is related when the handler returns more than one value:

delegate void ChipResponseHandler ([NullAllowed] NSError error, [NullAllowed] NSDictionary data);

The generator will tell you.

src/chip.cs Outdated
}

[Mac (12,0), Watch (8,0), TV (15,0), iOS (15,0), MacCatalyst (15,0)]
[BaseType (typeof(ChipCluster), Name="CHIPBinding")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[BaseType (typeof(ChipCluster), Name="CHIPBinding")]
[BaseType (typeof (ChipCluster), Name="CHIPBinding")]

same

src/chip.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@tj-devel709 tj-devel709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the missing spaces in the basetypes, it looks good to me!

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

12 tests failed, 77 tests passed.

Failed tests

  • framework-test/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)
  • framework-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
  • interdependent-binding-projects/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • dont link/iOS Unified 64-bits - simulator/Release: BuildFailure
  • dont link/watchOS 32-bits - simulator/Release: BuildFailure
  • link all/watchOS 32-bits - simulator/Release: BuildFailure
  • link sdk/watchOS 32-bits - simulator/Release: BuildFailure
  • MSBuild tests/Integration: Failed (Execution failed with exit code 45)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 27)

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 1d6fac0 into b1e8b29

src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 805652d into 870ffa0

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge e1a541e into 3240249

Comment on lines 603 to 607
#if !MONOMAC
if (t.Namespace == "Chip" && Runtime.Arch == Arch.SIMULATOR) // namespace not present in sims as of Xcode13 beta 1
continue;
#endif

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic should go in the Skip method, possibly in the MacApiProtocolTest subclass.

Comment on lines +783 to +784
[Async (ResultTypeName = "ChipReadAttributeResult")]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The [Async] attribute should be one liner lower.

Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the comments are addressed 👍

src/chip.cs Outdated

[Async (ResultTypeName = "ChipReadAttributeResult")]
[Export ("disableNetwork:breadcrumb:timeoutMs:responseHandler:")]
void DisableNetwork (NSData networkID, ulong breadcrumb, uint timeoutMs, ChipResponseHandler responseHandler);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other ID that needs to be Id

Suggested change
void DisableNetwork (NSData networkID, ulong breadcrumb, uint timeoutMs, ChipResponseHandler responseHandler);
void DisableNetwork (NSData networkId, ulong breadcrumb, uint timeoutMs, ChipResponseHandler responseHandler);

src/chip.cs Outdated
bool PairDevice (ulong deviceID, string address, ushort port, ushort discriminator, uint setupPinCode, [NullAllowed] out NSError error);

[Export ("pairDeviceWithoutSecurity:address:port:error:")]
bool PairDeviceWithoutSecurity (ulong deviceID, string address, ushort port, [NullAllowed] out NSError error);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same search and replace.

Suggested change
bool PairDeviceWithoutSecurity (ulong deviceID, string address, ushort port, [NullAllowed] out NSError error);
bool PairDeviceWithoutSecurity (ulong deviceId, string address, ushort port, [NullAllowed] out NSError error);

src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
@mandel-macaque mandel-macaque changed the title [CHIP] Add support for Xcode13 beta1. [CHIP] Add support for Xcode13 beta2. Jun 28, 2021
mandel-macaque and others added 2 commits June 28, 2021 18:26
Co-authored-by: Alex Soto <alex@alexsoto.me>
Co-authored-by: Alex Soto <alex@alexsoto.me>
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

11 tests failed, 78 tests passed.

Failed tests

  • monotouch-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
  • framework-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • interdependent-binding-projects/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • dont link/iOS Unified 64-bits - simulator/Release: BuildFailure
  • dont link/watchOS 32-bits - simulator/Release: BuildFailure
  • link all/watchOS 32-bits - simulator/Release: BuildFailure
  • link sdk/watchOS 32-bits - simulator/Release: BuildFailure
  • MSBuild tests/Integration: Failed (Execution failed with exit code 45)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 27)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge e416449 into e2a92c1

@@ -222,6 +222,7 @@ public void GatherFrameworks ()
case "Metal":
case "MetalKit":
case "MetalPerformanceShaders":
case "CHIP":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalexsoto out of curiosity, why doesn't the default case handle this?

if (App.IsSimulatorBuild && !App.IsFrameworkAvailableInSimulator (framework.Name)) {
if (App.LinkMode != LinkMode.None) {
ErrorHelper.Warning (5223, Errors.MX5223, framework.Name, App.PlatformName);
} else {
Driver.Log (3, Errors.MX5223, framework.Name, App.PlatformName);
}
continue;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfbjarne good question, I did not have a close look at it I wonder if there is a casing issue somewhere @mandel-macaque looks like we'll need to check deeper

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking atm.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

4 tests failed, 85 tests passed.

Failed tests

  • monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2451 Passed: 2389 Inconclusive: 10 Failed: 1 Ignored: 61)
  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2622 Passed: 2488 Inconclusive: 36 Failed: 1 Ignored: 133)
  • monotouch-test/tvOS - simulator/Debug: Failed
  • Xtro/Mac: BuildFailure

Pipeline on Agent XAMBOT-1104.BigSur'
Merge c2c366c into a64b030

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 89 tests passed 🎉

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 68837db into 0bfb745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants