Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MediaToolbox] Don't use Action<T> in reverse P/Invokes. #11541

Merged
merged 1 commit into from
May 13, 2021
Merged

[MediaToolbox] Don't use Action<T> in reverse P/Invokes. #11541

merged 1 commit into from
May 13, 2021

Conversation

rolfbjarne
Copy link
Member

CoreCLR doesn't support it.

Ref: dotnet/runtime#32963

@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label May 13, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)

Test results

1 tests failed, 81 tests passed.

Failed tests

  • introspection/Mac Modern/Debug: Failed (Test run failed.
    Tests run: 35 Passed: 33 Inconclusive: 0 Failed: 1 Ignored: 1)

Pipeline on Agent XAMBOT-1108.BigSur'
Merge dae1569 into 4fb1707

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2438).

@rolfbjarne rolfbjarne merged commit 23fedf8 into xamarin:main May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @spouliot @mandel-macaque