Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marshal-ilgen component must be included #16836

Closed
naricc opened this issue Nov 18, 2022 · 3 comments
Closed

marshal-ilgen component must be included #16836

naricc opened this issue Nov 18, 2022 · 3 comments
Labels
feature A feature to be implemented
Milestone
.NET 8

Comments

@naricc
Copy link

naricc commented Nov 18, 2022

After reverting, marshal-ilgen has been moved to again component: dotnet/runtime#75542. This is a step in eventually allowing the component to be dropped when not needed (reducing the runtime size by around 100kb). For now, it must be available to the runtime. So it needs to be added here before this change is consumed by xamarin-macios.

@dalexsoto @rolfbjarne
@rolfbjarne rolfbjarne added this to the .NET 8 milestone Nov 23, 2022
@rolfbjarne rolfbjarne added the feature A feature to be implemented label Nov 23, 2022
@rolfbjarne
Copy link
Member

This is the issue for the first attempt: #15668

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Nov 23, 2022
@rolfbjarne
[dotnet] Include the marshal-ilgen component. Fixes xamarin#16836.
83370b0 
Fixes xamarin#16836.
@rolfbjarne
Copy link
Member

This is probably the fix: rolfbjarne@83370b0, but waiting for the dotnet/runtime bump containing the marshal-ilgen component for now.

@rolfbjarne rolfbjarne mentioned this issue Feb 23, 2023
Merged
vs-mobiletools-engineering-service2 pushed a commit to vs-mobiletools-engineering-service2/xamarin-macios that referenced this issue Feb 23, 2023
@rolfbjarne
[dotnet] Include the marshal-ilgen component. Fixes xamarin#16836.
e6ac319 
Fixes xamarin#16836.
Merged
rolfbjarne added a commit that referenced this issue Feb 24, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/8.0.1xx-preview1] [dotnet] Include the marshal-ilgen compone…
1f23bd6 
…nt. Fixes #16836. (#17607)

Fixes #16836.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1751368.


Backport of #17606

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
rolfbjarne added a commit that referenced this issue Feb 24, 2023
@rolfbjarne
[dotnet] Include the marshal-ilgen component. Fixes #16836. (#17606)
e0c92a0 
Fixes #16836.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1751368.
@rolfbjarne
Copy link
Member

This is complete now.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature A feature to be implemented
Projects
None yet
Milestone
.NET 8
Development

No branches or pull requests
2 participants
@rolfbjarne @naricc