-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KotlinX.Coroutines 1.4.1 #1050
KotlinX.Coroutines 1.4.1 #1050
Conversation
waiting #987 to be merged |
Must check possible duplicate: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to prefix nugets/namespaces/assemblies with Xamarin if author is Microsoft.
Antonio I had to bind really fast 2 new bindings for 4-5 new AndroidX artifacts ( Would it be possible to add remaining stuff to Kotlin folder? IMO this will be most likely updated all together (though not sure) |
I prefer not to put in Kotlin folder KotlinX is released separately. I think it is better to be decoupled. I change rootnamespace and binding namespace. Currently working on sample app (plan to finish it today) |
Don't forget nuget packagenames prefix please |
OK. I will publish 1.3.4 from other PR and then delete it afterwards. |
…oroutines-1.4.1 # Conflicts: # manifest.yaml
Any news on this? 😊 |
@moljac can we merge this and publish nugets? |
Any news on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Namespace that is not renamed or hidden:
### New Namespace Kotlin.Coroutines.Jvm.Internal
@@ -0,0 +1,6 @@ | |||
<metadata> | |||
|
|||
<attr path="/api/package[@name='kotlinx.coroutines.android']" name="managedName">Xamarin.KotlinX.Coroutines.CoroutinesAndroid</attr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to pick a standard capitalization for Kotlinx
/KotlinX
and be consistent with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing all to KotlinX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like our existing packages have already committed to KotlinX
:
https://www.fuget.org/packages/Xamarin.KotlinX.Coroutines.Core/1.3.4
😉
@@ -0,0 +1,55 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to bind these libraries that aren't intended for Android:
- Xamarin.Kotlinx.Coroutines.Core.Jvm
- Xamarin.Kotlinx.Coroutines.Core.Jdk8
- Xamarin.Kotlinx.Coroutines.Core.Reactive
- Xamarin.Kotlinx.Coroutines.Core.Rx2
Today it looks like we only publish 2 packages:
- Xamarin.KotlinX.Coroutines.Core
- Xamarin.KotlinX.Coroutines.CoroutinesAndroid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today it looks like we only publish 2 packages:
I think I bound those from Kotlin folder, just minimal dependencies I needed for GPS-FB-MLKit.
So, deleting or not publishing other packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependencies listed:
-
kotlinx-coroutines-android
-
dependencies
-
kotlin-stdlib
-
kotlinx-coroutines-core-jvm
-
-
-
kotlinx-coroutines-core-jvm
-
dependencies
-
kotlin-stdlib
-
kotlin-stdlib-common
-
-
-
kotlinx-coroutines-jdk8
-
dependencies
-
kotlin-stdlib
-
kotlinx-coroutines-core-jvm
-
-
-
kotlinx-coroutines-reactive
-
dependencies
-
kotlin-stdlib
-
kotlinx-coroutines-core-jvm
-
org.reactivestreams:reactive-streams
-
-
-
kotlinx-coroutines-rx2
-
dependencies
-
kotlin-stdlib
-
kotlinx-coroutines-core-jvm
-
io.reactivex.rxjava2:rxjava
-
kotlinx-coroutines-reactive
-
-
Already bound:
Kotlin.StdLib
Xamarin.Android.ReactiveStreams
RxJava
So seem like those could be used on Android and it
because of conflicts manual merge had to be performed. branch: https://github.com/xamarin/XamarinComponents/tree/antonioseric-KotlinxCoroutines-1.4.1 PR: #1155 |
closing this PR. Published from other PR/branch after manual merging |
No description provided.