Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Tizen] Supports Custom/Embedded and System fonts #9138

Merged
merged 6 commits into from
Jan 13, 2020
Merged

[Tizen] Supports Custom/Embedded and System fonts #9138

merged 6 commits into from
Jan 13, 2020

Conversation

rookiejava
Copy link
Collaborator

Description of Change

This PR allows you to use custom fonts in Tizen in the same way as other platforms (android, iOS, UWP). (This is the tizen implementation of #6013.) Plus, this also allows you to use system built-in fonts.

Issues Resolved

None

API Changes

Added: (New classes)
Xamarin.Forms.Platform.Tizen

  • EmbeddedFontLoader
  • FontExtensions

Platforms Affected

  • Tizen

Behavioral/Visual Changes

Users can continue to use fonts as they want. However it now allows us to embed fonts as Resources. This also allows us to declare custom fonts in a uniformed way as followings.

FontFamily ="CuteFont-Regular" // OK
FontFamily = "Dokdo" // OK
FontFamily = "PTM55FT#PTMono-Regular" // OK
FontFamily = "fa-regular-400.ttf#FontAwesome5Free-Regular" // OK

Before/After Screenshots

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts changed the base branch from master to 4.5.0 January 10, 2020 21:37
@samhouts samhouts changed the base branch from 4.5.0 to master January 10, 2020 21:37
@samhouts
Copy link
Member

@rookiejava do you want to rebase to 4.5.0? Thanks!

@samhouts samhouts assigned samhouts and unassigned rmarinho Jan 10, 2020
@samhouts samhouts added t/enhancement ➕ approved Has two approvals, no pending reviews, and no changes requested labels Jan 10, 2020
@rookiejava rookiejava changed the base branch from master to 4.5.0 January 12, 2020 21:35
@rookiejava
Copy link
Collaborator Author

@samhouts I've rebased to 4.5.0. Thanks!

@samhouts samhouts merged commit 1b169f4 into xamarin:4.5.0 Jan 13, 2020
samhouts added a commit that referenced this pull request Jan 13, 2020
@samhouts
Revert "[Tizen] Supports Custom/Embedded and System fonts (#9138)"
496e546 
This reverts commit 1b169f4.
samhouts added a commit that referenced this pull request Jan 13, 2020
@samhouts
Undo unrelated changes from #9138
e2414c0
@samhouts samhouts mentioned this pull request Jan 13, 2020
Merged
samhouts added a commit that referenced this pull request Jan 14, 2020
@samhouts
Undo unrelated changes from #9138 (#9192)
6eb2667
@rookiejava rookiejava deleted the custom-font-tizen branch January 14, 2020 06:07
@samhouts samhouts added this to the 4.5.0 milestone Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samhouts samhouts samhouts approved these changes

Assignees

@samhouts samhouts

Labels
a/fonts approved Has two approvals, no pending reviews, and no changes requested p/Android p/Tizen t/enhancement ➕
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rookiejava @samhouts @rmarinho @PureWeen @LuoyeAn