Commits on Jan 7, 2020

1. [android] remove Anticipator.cs for now …

   Context: https://github.com/jonathanpeppers/anticipator
   Context: xamarin#8245
   
   I was profiling the Blank Xamarin.Forms app template and saw this:
   
       Method call summary
       Total(ms) Self(ms)      Calls Method name
          40095        0         11 (wrapper runtime-invoke) <Module>:runtime_invoke_void__this___object (object,intptr,intptr,intptr)
          40094        0          8 System.Threading.ThreadHelper:ThreadStart (object)
          40094        0          8 System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
          40094        0          8 System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
          40094        0          8 System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
          40092        0          8 System.Threading.ThreadHelper:ThreadStart_Context (object)
          40092        0          8 Xamarin.Forms.Platform.Android.Anticipator:Loop (object)
          40035        0         16 System.Threading.WaitHandle:WaitOne (System.TimeSpan)
          40035        0         16 System.Threading.WaitHandle:WaitOne (System.TimeSpan,bool)
          40035        0         16 System.Threading.WaitHandle:WaitOne (long,bool)
          40035        0         16 System.Threading.WaitHandle:InternalWaitOne (System.Runtime.InteropServices.SafeHandle,long,bool,bool)
          40034        0         16 System.Threading.WaitHandle:WaitOneNative (System.Runtime.InteropServices.SafeHandle,uint,bool,bool)
          40034    40034         16 (wrapper managed-to-native) System.Threading.WaitHandle:Wait_internal (intptr*,int,bool,int)
   
   The `Anticipator` class stuck out, so I profiled it separately in a
   blank app (not using Xamarin.Forms at all). This project isolates the
   `Anticipator`, in timing specifically `Build.VERSION.SdkInt` and the
   `Resource.designer.cs` class. This launches an app 10 times and
   averages the result.
   
   The results were that it hurt performance in every scenario:
   
       HAXM Emulator / Debug
           Anticipator: 141.273
           No Anticipator: 108.182
       HAXM Emulator / Release
           Anticipator: 86.182
           No Anticipator: 63.545
       Pixel 3XL / Debug
           Anticipator: 101.545
           No Anticipator: 93.182
       Pixel 3XL / Release
           Anticipator: 45.818
           No Anticipator: 38.455
       Pixel 3XL / Release+AOT
           Anticipator: 33.636
           No Anticipator: 30.545
   
   Feel free to try out my sample as additional verification.
   
   I would recommend removing this class for now, and only bring it back
   when we have some numbers showing it improves things. Sorry!

   

   jonathanpeppers committed Jan 7, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 1bcd7a2
   • Browse repository at this point

   Copy the full SHA

   1bcd7a2 View commit details

   Browse the repository at this point in the history