This repository has been archived by the owner on May 1, 2024. It is now read-only.
Remove Material Frame Renderer from Frame element on dispose of renderer #7752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
approved these changes
Oct 2, 2019
samhouts
added
the
in-progress
samhouts
removed
the
in-progress
rmarinho
approved these changes
Oct 3, 2019
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
…rer (xamarin#7752) fixes xamarin#7339 * [iOS] remove renderer from Frame on dispose * - add uitests
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
…rer (xamarin#7752) fixes xamarin#7339 * [iOS] remove renderer from Frame on dispose * - add uitests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Material Frame Renderer on iOS wasn't clearing the bindable renderer property on dispose so when the Frame was reused it would cause a dispose exception
Issues Resolved
Platforms Affected
Testing Procedure
PR Checklist