-
Notifications
You must be signed in to change notification settings - Fork 1.9k
ItemsViewController
null checks
#15638
ItemsViewController
null checks
#15638
Conversation
@reid-kirkpatrick I just created a patch and saw that you already fixed it last week. Thanks! @jfversluis can this one please be merged and released on short notice? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks for this @reid-kirkpatrick ! Appreciate you looking into this and opening a PR! Don't think this is a shocking change so I don't see any issues merging this. Releasing on short notice I can't promise, but it will be part of the next service release when merged. |
Thanks @jfversluis and @reid-kirkpatrick ! |
Confirmed here that this build works. Thanks again @reid-kirkpatrick ! |
@jfversluis , do we have any ETA of Xamarin.Forms 5.0 SR 14 where this fix will be included? |
@jfversluis any update here? We just released a new version of our app that added some uses of controls affected by this and our crash rate is a little troubling. |
Working on a new SR, should be soon. Hoping next week, but no solid promises at this point. |
@jfversluis 🙏 thank you! |
@jfversluis any news on the SR for this week? Pretty please. |
@oridotaoyebode it has been released yesterday |
Description of Change
In the
ItemsViewController
multiple methods (i.e.UICollectionViewController.GetCell()
which callsItemsViewController.UpdateTemplatedCell()
andUICollectionViewController.GetItemsCount()
andUICollectionViewController.NumberOfSections()
which both callItemsViewController.CheckForEmptySource()
) can be called by iOS afterItemsViewController.Dispose()
has been called and_measurementCells
has been set tonull
. There are already null checks for_measurementCells
in certain places, but not all. This should cover the rest of the cases where it can be null.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
I was able to reproduce the crash in the attached sample from #15637. I then created a local nuget package from the 5.0.0 branch and confirmed the cause. After making these changes I created another nuget package, updated the repro sample and confirmed the crash no longer happened.
PR Checklist