This repository has been archived by the owner on May 1, 2024. It is now read-only.
Account for RTL on Android Tablet #15417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔥 |
PureWeen
added
the
DO-NOT-MERGE-!!! 🛑
PureWeen
removed
the
DO-NOT-MERGE-!!! 🛑
jfversluis
force-pushed
the
fix_rtl_tablet_android
branch
from
a0b035f
to
501d331
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The original RTL PR didn't test on an Android tablet so AFAICT this has never really worked on an Android Tablet.
The split mode on Android is a bit of a hack of the drawer layout. It forces the flyout to be visible and then we calculate the layout bounds ourselves.
Side note :-) This all works fine in MAUI because on MAUI when using split mode the flyout and details are just moved to a linear layout. This means the platform is able to apply RTL without us having to do anything magical.
Issues Resolved
PICTURES