This repository has been archived by the owner on May 1, 2024. It is now read-only.
Comment out measure all strategy on iOS 15 for grouping #15355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not using the MeasureAll mode already to "fix" this issue. It will fix the crash but the cell still won't auto resize. I know that's by design on iOS as to resize a cell you must replace it (ie: delete and insert in the same transation). |
|
Sounds like you've got a better method in mind, I'll be happy to hear it or see a PR :) Although I think this only skips the invalidate for header cells, right? |
rotorgames
pushed a commit
to rotorgames/Xamarin.Forms
that referenced
this pull request
Jun 22, 2022
* Update ItemsViewLayout.cs * Update ItemsViewLayout.cs * Make check for iOS 15.4 and higher # Conflicts: # Xamarin.Forms.Platform.iOS/Forms.cs
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Porting (potential) fix from .NET MAUI to Forms. Also see: dotnet/maui#6878
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist