Android CarouselViewRenderer should call base UpdateItemsSource and UpdateAdapter #15266
Conversation
|
Would you be able to pull in the latest changes I just merged or rebase? That will make sure the build runs again. Thank you so much for this contribution! |
danielcaceresm
force-pushed
the
carousel-android-itemssource-scroll
branch
from
6956fb2
to
49107ea
Compare
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
|
I haven't tried running it, but it looks like the same problem will exist in Maui: |
|
@GalaxiaGuy we haven't even confirmed this is working for Forms as you said you didn't run it yet so let's make sure that we fix it here first and then look at porting it to .NET MAUI :) |
|
Sorry for the confusion. This works for me on Android, I haven't tried running Maui. |
jfversluis
force-pushed
the
carousel-android-itemssource-scroll
branch
from
49107ea
to
c3b3aa0
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
…pdateAdapter to reset scroll listener and observers
jfversluis
force-pushed
the
carousel-android-itemssource-scroll
branch
from
c3b3aa0
to
1ad01f9
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Is there any update on this and when it may be merged? |
|
My intention is to merge this before the next release! |
|
Hey @jfversluis My apologies if this is a dumb question. When do you plan on releasing a xamarin forms update with this issue fixed? Is there any way that I can test? Thank you |
|
Hey, any news on the release date? |
|
This has already been released in version 5.0.0.2478 11 days ago. |
Description of Change
Android CarouselViewRenderer should call base UpdateItemsSource and UpdateAdapter to reset scroll listener and observers
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist