This repository has been archived by the owner on May 1, 2024. It is now read-only.
CSS: Support omitting semicolon from last property #14306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[
main
may be the more appropriate branch, but it's a relatively small change. ]The current CSS parser doesn't support declarations like
label {font-size: 18; background-color: red}
where the final semicolon is omitted. These are, however, valid CSS.This fixes that behavior and introduces a few unit tests to check for such edge cases.
Issues Resolved
Testing Procedure
Run all tests in the
Xamarin.Forms.Core.UnitTests.StyleSheets
andXamarin.Forms.StyleSheets.UnitTests
namespaces.PR Checklist