Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Picker - Fix VoiceOver reading reading row twice #14209

Merged
merged 5 commits into from
Jan 14, 2022

Conversation

MichaelLHerman
Copy link
Contributor

Description of Change

Not reloading UIPickerView on every Picker SelectedItem change

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Added manual UITest

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@net-foundation-cla
Copy link

net-foundation-cla bot commented Apr 23, 2021

CLA assistant check
All CLA requirements met.

@MichaelLHerman MichaelLHerman changed the title only reload picker on collection change [iOS] Picker - Fix VoiceOver reading reading row twice Apr 23, 2021
@rachelkang
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis
Copy link
Member

Third time is the charm 🍀

@jfversluis
Copy link
Member

@MichaelLHerman sorry this took a while, thank you for your patience, just checked this one and seems OK to me. Thank you so much for your time and effort on this. Xamarin.Forms apps are again a little more accessible thanks to you!

@jfversluis jfversluis merged commit 576d9c6 into xamarin:5.0.0 Jan 14, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double prompt when voice over reads picker item on iOS
4 participants