Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Gtk] Implement RadioButton #14166

Merged
merged 5 commits into from
Jan 14, 2022
Merged

Conversation

JunielKatarn
Copy link
Contributor

Description of Change

Adds missing implementation of RadioButton for Gtk.

Issues Resolved

None

API Changes

Added:

  • class Xamarin.Forms.Platform.GTK.Controls.RadioButton
  • Xamarin.Forms.Platform.GTK.Renderers.RadioButtonRenderer

Platforms Affected

  • Gtk

Behavioral/Visual Changes

RadioButtons under Gtk get rendered, shown, and behave consistently with other platforms.

Before/After Screenshots

Not applicable

Testing Procedure

  1. Start ControlGallery.Gtk.
  2. Open the RadioButtonGroup page.
  3. Verify RadioButtons show up and grouping behavior works.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz
Copy link
Contributor

Thanks for the contribution @JunielKatarn!

@JunielKatarn
Copy link
Contributor Author

Thanks for the contribution @JunielKatarn!

My pleasure!
Anything else needed to merge this change?

@JunielKatarn
Copy link
Contributor Author

Hey @jsuarezruiz. Is this change good to go?

@jfversluis
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis
Copy link
Member

Technically we're not adding anything new to Forms anymore, but since the GTK backend is supported by the community anyway this shouldn't add to our load here.

Thanks for your contribution @JunielKatarn !

@jfversluis jfversluis merged commit f01d21d into xamarin:5.0.0 Jan 14, 2022
@jfversluis jfversluis mentioned this pull request Jan 14, 2022
2 tasks
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants