This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Core] Fix Shapes issue using AppThemeBinding #13181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rachelkang
reviewed
May 3, 2021
There was a problem hiding this comment.
Created this sample based on the original issue and applied the nuget. On Android, it works great. On iOS, it works fine if I rebuild after switching the app theme, but not if I just switch the app theme and then return to the running app. Looks great in CG on both platforms for both scenarios though
|
Hi @jfversluis , |
|
@AlleSchonWeg NuGet should be here, let me know if it looks OK to you! |
|
@jfversluis |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix Shapes issue using AppThemeBinding with SolidColorBrush.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issue 13173. Change between system dark and light theme. If the Rectangle is green with the light theme and red with the dark theme, the test has passed.
PR Checklist