This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Allow VC renderers of FlyoutPage to specify UIStatusBarStyle #13143
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
02ce770
[Controls] Add reproduction sample for issue #13053
rmarinho 9ca3caa
[iOS] Internal ChildViewController should specify the real renderer t…
rmarinho 69b2452
Update Xamarin.Forms.ControlGallery.iOS.csproj
rmarinho b0d5213
Merge branch '5.0.0' into fix-13053
jsuarezruiz 4e6fcba
[iOS] Use index to find the correct ChildViewControllers
rmarinho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
Xamarin.Forms.ControlGallery.iOS/CustomRenderers/UIStatusBarStyleRenderer.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
using UIKit; | ||
using Xamarin.Forms.Platform.iOS; | ||
|
||
namespace Xamarin.Forms.ControlGallery.iOS.CustomRenderers | ||
{ | ||
public class DetailPageStatusBarRenderer : NavigationRenderer | ||
{ | ||
public override UIStatusBarStyle PreferredStatusBarStyle() | ||
{ | ||
return UIStatusBarStyle.DarkContent; | ||
} | ||
} | ||
|
||
public class FlyoutPageStatusRenderer : PageRenderer | ||
{ | ||
public override UIStatusBarStyle PreferredStatusBarStyle() | ||
{ | ||
return UIStatusBarStyle.LightContent; | ||
} | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChildViewControllers is an array - can we just check the last index instead of allocating an enumerator?
Also, are we guaranteed that the last controller in the array is the correct one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it @hartez , this ChildVIewController wrapper is internal and we are the only ones adding to it the detail or flout as a children, it's the only children.