This repository has been archived by the owner on May 1, 2024. It is now read-only.
[X] ConvertToInvariant is invariant #12834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
added
the
external-hotreload
etvorun
reviewed
Nov 13, 2020
| @@ -58,7 +58,7 @@ public override string ConvertToInvariantString(object value) | |||
| { | |||
| if (!(value is CornerRadius cr)) | |||
| throw new NotSupportedException(); | |||
| return $"{cr.TopLeft}, {cr.TopRight}, {cr.BottomLeft}, {cr.BottomRight}"; | |||
| return $"{cr.TopLeft.ToString(CultureInfo.InvariantCulture)}, {cr.TopRight.ToString(CultureInfo.InvariantCulture)}, {cr.BottomLeft.ToString(CultureInfo.InvariantCulture)}, {cr.BottomRight.ToString(CultureInfo.InvariantCulture)}"; | |||
There was a problem hiding this comment.
nit: instead of repeating CultureInfo.InvariantCulture multiple times consider using denser form
string.Format(CultureInfo.InvariantCulture, "{0}, {1}, {2}, {3}", cr.TopLeft, cr.TopRight, cr.BottomLeft, cr.BottomRight);
There are other places like this
There was a problem hiding this comment.
You could also do:
FormattableString.Invariant($"{cr.TopLeft}, {cr.TopRight}, {cr.BottomLeft}, {cr.BottomRight}");There was a problem hiding this comment.
@GalaxiaGuy nice tip. but we still need to support netstandard1.0 :(
There was a problem hiding this comment.
@etvorun I choose to keep named parameters instead of reverting to positional
etvorun
approved these changes
Nov 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[X] ConvertToInvariant is invariant
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist