This repository has been archived by the owner on May 1, 2024. It is now read-only.
Remove TargetSdkVersion check for AndroidX fallback #12825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelkang
approved these changes
Nov 12, 2020
samhouts
added
Android10
blocker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If users have the non AndroidX layouts that come with the Forms template and they upgrade to AndroidX then we fallback to AndroidX layouts included with our binaries. We were checking that the targetSdk >= 29 but in some rare cases users might have targetSdk set to 28 and the compile target set to 29. This removes the requirement for targetSdk > 28 for it to trigger our fallbacks.
The Android team is going to work on putting together some better warning messages around this mismatch with the 16.9 release
Issues Resolved
Platforms Affected
Testing Procedure
PR Checklist