Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Check for Internet Connection before running tests that Require an Internet Connection #12790

Merged
merged 7 commits into from
Nov 10, 2020

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Nov 9, 2020

Description of Change

  • Categorize tests that require internet access that are currently failing on App Center
  • Before these tests run verify if the device has a valid internet connection. If it doesn't then just mark the test as Inconclusive
  • For the most part tests inside of AppCenter run without issue but the internet connection on the device seems to fail enough that we need to detect for this and not fail the whole group but just mark a given set inconclusive

Platforms Affected

  • iOS
  • Android
  • UWP

Testing Procedure

  • Make sure UI tests all pass

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen requested a review from hartez November 10, 2020 01:16
@hartez hartez merged commit 640377c into 4.8.0 Nov 10, 2020
@hartez hartez deleted the uitest_check_for_internet branch November 10, 2020 16:54
@samhouts samhouts added this to the 4.8.0 milestone Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants