This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Core] Brushes working with DynamicResource #12761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug 🐛
a/Xaml </>
blocker
StephaneDelcroix
approved these changes
Nov 9, 2020
| @@ -87,5 +89,12 @@ public Stretch Aspect | |||
| set { SetValue(AspectProperty, value); } | |||
| get { return (Stretch)GetValue(AspectProperty); } | |||
| } | |||
|
|
|||
| static void OnBrushChanged(BindableObject bindable, object oldValue, object newValue) | |||
There was a problem hiding this comment.
you need some code (and unit test) to unparent Brushes
rmarinho
approved these changes
Nov 10, 2020
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changed Brush and GradientStop from BindableProperty to Element and propagate correctly the Parent.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issues 11696 and 11911. Verify that the expected colors are rendered (read issue instructions).
PR Checklist