Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix APK to build with Fast Renderer switch when running on CI #12640

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Fix APK to build with Fast Renderer switch when running on CI #12640

merged 3 commits into from
Oct 28, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

  • Replaced the "TEXT_EXPERIMENTAL_RENDERERS" constant with "LEGACY_RENDERERS" as that's a more accurate indicator of the current state of the renderers
  • Fixed CI to default to Fast Renderers instead of Legacy Renderers

Platforms Affected

  • Android

Testing Procedure

  • Make sure a Legacy Renderer and Fast Renderer APK is built
  • Even if the tests are failing we should merge this PR in and then fix the tests on other PRs

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rmarinho rmarinho merged commit 45259a4 into 4.8.0 Oct 28, 2020
@rmarinho rmarinho deleted the fix_fast_renderers_build branch October 28, 2020 19:32
@samhouts samhouts added this to the 4.8.0 milestone Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PureWeen @rmarinho @samhouts